Re: [libvirt] [PATCH 2/2] qemu: add usb-serial support
On 01/05/2013 04:24 AM, Eric Blake wrote:
Overall it looks reasonable, but depending on the answer to whether
we
should just always output type='isa-serial', you may have a v2 to submit.
As attribute 'type' is optional, my initial thoughts is that If
type='value' is given
explicitly on input, then we print it out on output too, if no type
is given on input,
we don't print it out on output either. Backward compatibility and
being more flexible.
There are indeed a number of testcases we need to modify if we
always output
type='isa-serial', but not a big workload.
Guannan