Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38
On Wed, May 03, 2023 at 09:24:45AM +0100, Andrea Bolognani wrote:
On Wed, May 03, 2023 at 09:19:10AM +0200, Erik Skultety wrote:
> This depends on the corresponding changes in libvirt-perl and libvirt-python:
>
> https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/92
> https://gitlab.com/libvirt/libvirt-python/-/merge_requests/114
>
> Once those are in, I'll provide a link to a fresh libvirt proof pipeline.
>
> Erik Skultety (4):
> ci: Add Fedora 38 target
> ci: Drop Fedora 36 target
> ci: Flip mingw jobs from Fedora 37 to Fedora 38
> ci: integration: Flip QEMU upstream integration tests to Fedora 38
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Thanks!
So, I couldn't merge this just yet, as tests started failing on F38, here's an
MR with necessary fixes for that:
https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/41
Here's a pipeline including ^those fixes + Fedora 38 (as promised):
https://gitlab.com/eskultety/libvirt/-/pipelines/858474139
@abologna: After the lcitool refresh I also need this bit in to fix Leap 15.4:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3a36c0ef18..2378b1a39f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -118,10 +118,10 @@ codestyle_prebuilt_env:
- .codestyle_job
- .gitlab_native_build_job_prebuilt_env
needs:
- - job: x86_64-opensuse-leap-154-container
+ - job: x86_64-opensuse-leap-15-container
optional: true
variables:
- NAME: opensuse-leap-154
+ NAME: opensuse-leap-15
codestyle_local_env:
extends:
@@ -129,7 +129,7 @@ codestyle_local_env:
- .gitlab_native_build_job_local_env
variables:
IMAGE: registry.opensuse.org/opensuse/leap:15.4
- NAME: opensuse-leap-154
+ NAME: opensuse-leap-15
Please let me know if your RB still stands or whether I need to respin with
that change.
Regards,
Erik