Re: [libvirt] [PATCH] storage: Fix a potential crash when creating vol object

On 12/12/2011 12:26 AM, Osier Yang wrote: > If the vol object is newly created, it increases the volumes count, > but doesn't decrease the volumes count when do cleanup. It can > cause libvirtd crash when one trying to free the volume objects s/crash/to crash/ > like: > for (i = 0; i< pool->volumes.count; i++) > virStorageVolDefFree(pool->volumes.objs[i]); > > It's more reliale if we add the newly created vol object in the s/reliale/reliable/ > end. > --- > src/storage/storage_backend_logical.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) ACK.