Re: [libvirt] [PATCH 2/2] security: Implement virSecurityManagerSetHugepages
On Tue, Nov 22, 2016 at 01:45:43PM +0100, Michal Privoznik wrote:
Since its introduction in 2012 this internal API did nothing. Now
it's finally the right time to put it into a good use. It's
implementation is fairly simple and exactly the same as
virSecurityDomainSetPathLabel.
Then why do you redefine the function? Why not just say
.domainSetSecurityHugepages = …DomainSetPathLabel,
or simply:
s/virSecurityManagerDomainSetHugepages/virSecurityManagerDomainSetPathLabel/g
and zap the former function, qemuProcessPrepareHost() is the only caller
anyway.
ACK to any of those two (I prefer the latter).
Attachments:
- signature.asc (application/pgp-signature — 833Â bytes)