Re: [PATCH] libxl: Implement domainGetMessages API
On Tue, Dec 14, 2021 at 10:05:51 +0100, Peter Krempa wrote:
On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote:
> Since commit 46783e6307a, the 'virsh dominfo' command calls
> virDomainGetMessages to report any messages from the domain.
> Hypervisors not implementing the API now get the following
> log message when clients invoke 'virsh dominfo'
>
> this function is not supported by the connection driver: virDomainGetMessages
>
> Although libxl currently does not support any tainting or
> deprecation messages, provide an implementation to squelch
> the previously unseen error message when collecting dominfo.
So you are fixing a symptom, but IMO the proper fix is to just make
virsh ignore errors when virDomainGetMessages is not supported.
Okay, so I misread that because the error message you've posted here
doesn't look like message from the log. Spamming logs is not good, so
as said it's okay.