On Wed, Oct 14, 2015 at 04:59:04PM +0200, Andrea Bolognani wrote:
On Wed, 2015-10-14 at 14:54 +0200, Martin Kletzander wrote:
> > + <li>Portability:<br/>
> > + fix missing dep in spec file,<br/>
> > + fix compilation with new NUMA libraries (Daniel
> > Berrange),<br/>
>
> I don't know if that's worth fixing, but this way the first line is
> missing an attribution (is that the correct word, even?).
>
> There are few others throughout the file, but then again, does anyone
> really care?
My undertanding is that DV only added attribution for
changes made by other people, hence all changes with no
explicit attribution are to be considered his.
I don't think having explicit attribution is really
required - we haven't had it until now - but adding it
with a follow-up patch will be easy enough if we
decide it's something we're interested in.
You see and I understood it as something like:
'fix missing dep in spec file' and 'fix compilation with new NUMA
libraries' were done by Daniel Berrange.
I don't think we need to deal with that.
CCing DV for confirmation.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team