Re: [libvirt] [PATCH] remote: Fix TLS transport on Windows

>> This doesn't entirely make any sense to me. GNUTLS also uses GNULIB, >> including all its socket wrappers for send/recv. If the push/pull >> function is NULL, gnulib does this >> >> if (session->internals._gnutls_push_func == NULL) >> { >> i = send (GNUTLS_POINTER_TO_INT (fd), &ptr[n - left], left, 0); >> Okay, yes GnuTLS uses gnulib, but they explicitly don't use gnulib's replacements for send() and recv() on Windows. See lib/gnutls_buffers.c: /* We need to disable gnulib's replacement wrappers to get native Windows interfaces. */ #undef recv #undef send GnuTLS decided to use the native Windows versions of send() and recv(). This cannot be changed, as that would break existing applications using GnuTLS on Windows relying on GnuTLS using the native Windows versions of send() and recv(). Therefore, I think my patch is necessary, as libvirt requires GnuTLS to use gnulib's replacement functions.