On 03/18/2011 08:59 AM, Jean-Baptiste Rouault wrote:
This patch adds missing curly brackets to an if
statement in openvzListDefinedDomains()
---
src/openvz/openvz_driver.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 0d64e19..7792136 100644
--- a/src/openvz/openvz_driver.c
+++ b/src/openvz/openvz_driver.c
@@ -1444,9 +1444,10 @@ static int openvzListDefinedDomains(virConnectPtr conn
ATTRIBUTE_UNUSED,
continue;
}
snprintf(vpsname, sizeof(vpsname), "%d", veid);
- if (!(names[got] = strdup(vpsname)))
+ if (!(names[got] = strdup(vpsname))) {
virReportOOMError();
goto out;
+ }
Oh my. ACK and pushed.
Last time we found one of these nasty bugs, Jim was proposing the idea
of a code-indenter run, and look through the diff to see if
reindentations spot any bugs, but the diff ended up too large to be useful.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org