Re: [libvirt] [PATCH]virsh: track alias option and improve error message when option duplicate its alias

> if ((*opts_seen & (1 << i)) && opt->type != VSH_OT_ARGV) { > - vshError(ctl, _("option --%s already seen"), name); > - goto cleanup; > + if ((*opts_seen & (1 << (i - 1)))) { > + vshError(ctl, _("option '--%s' duplicates its alias '--%s'"), > + cmd->opts[i].name, cmd->opts[i-1].name); This is not right. This code depends on the aliased option being right before the target option in the array describing the options. If you move the options in the array around you may get strange error messages.

The idea is good, but you need to make sure that the code doesn't depend on ordering of the options in the array.