Re: [libvirt] [PATCHv2 8/8] Remove bogus includes
On Tue, Nov 23, 2010 at 04:50:01PM -0700, Eric Blake wrote:
From: Daniel P. Berrange <berrange(a)redhat.com>
---
v2: rearrange to later in the series; no other change. Passes
for me with macvtap compilation enabled, so I'm not sure if it
still suffers from the same problem as the v1 complaint:
https://www.redhat.com/archives/libvir-list/2010-November/msg00834.html
src/conf/domain_conf.c | 1 -
src/util/hooks.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
ACK
The problem I hit was actually with removing
diff --git a/src/util/macvtap.c b/src/util/macvtap.c
index 5dcc9e1..eb4ea8f 100644
--- a/src/util/macvtap.c
+++ b/src/util/macvtap.c
@@ -49,7 +49,6 @@
# include "logging.h"
# include "macvtap.h"
# include "interface.h"
-# include "conf/domain_conf.h"
Because the 'util' directory must never depend on the 'conf' directory.
Daniel