Re: [Libvir] [PATCH] Add virConnectGetHostname and virConnectGetURI calls, virsh commands, and some related fixes
On Tue, Jun 26, 2007 at 01:21:35PM +0100, Richard W.M. Jones wrote:
Daniel Veillard wrote:
>On Tue, Jun 26, 2007 at 11:09:21AM +0100, Richard W.M. Jones wrote:
>>I haven't updated the Python bindings, but will do so next.
>
> it's probable that those 2 calles will be handled automatically
>since the arg is a known structure and the return value is a string.
>It's a matter of rebuilding the API xml with the new headers once applied
>and let the generator do its job.
Rather obscurely, docs/apibuild.py was having trouble parsing
remote_internal.c, which was causing the API XML files not to build,
which was causing the Python API not to build correctly either.
yeah the C parser of apibuild can be nasty at times,
Attached patch corrects that, corrects a bug in python/Makefile.am
(libvirt.py not being rebuilt), and rearranges python/Makefile.am to
make it a bit easier to understand.
So now it does build Python bindings for getHostname and getURI.
Looks fine, +1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/