Re: [libvirt] [PATCHv2 2/2] remote: react to failures on wakeupFD

>> This looks fine, but "errno ? errno : 0" is equivalent to just "errno". >> Which makes me think you'll want to separate the saferead-fails case >> (where errno is nonzero) from the >> saferead-returns-non-negative-<=-sizeof-ignore case (in which >> case virReportSystemError would print "Success" for errno=0). > > Is this rewrite more what you had in mind? (No change to patch 1/2). Thanks. That looks better. No more "Success" diagnostic upon error.