Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations
Hello Zhao,
On Wed, 6 Mar 2024 at 08:49, Zhao Liu <zhao1.liu(a)linux.intel.com> wrote:
> then checking 'config->has_maxcpus ?' above is
probably not required I
> think. It could just be
>
> maxcpus = config->maxcpus
Yes.
> If a user does not specify config->maxcpus with -smp option, then it
> could default to zero(0) in 'config' parameter? (same for other config
> fields)
Yes. I could post another series for this cleanup soon.
The above change you suggested doesn't require API changes ;-).
* Great! (Communication is the most difficult skill to master. :))
* If you plan to send a separate patch for above refactoring, then I'd
add Reviewed-by for this one.
Reviewed-by: Prasad Pandit <pjp(a)fedoraproject.org>
Thank you.
---
- Prasad