Re: [PATCH] Drop needless variable
On Tue, May 05, 2020 at 10:47:13AM +0200, Erik Skultety wrote:
On Tue, May 05, 2020 at 10:46:28AM +0200, Erik Skultety wrote:
> On Mon, May 04, 2020 at 05:13:08PM +0200, Michal Privoznik wrote:
> > Instead of the following pattern:
> >
> > type ret;
> > ...
> > ret = func();
> > return ret;
> >
> > we can use:
> >
> > return func()
> >
> > directly.
> >
> > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> > ---
> Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Also, SFF
Well, libvirt was already released and no this is not SFF as it's not
fixing bug or any critical issue or regression or anything like that.
The patch looks simple and probably is and will not break anything but
that doesn't justify it to be pushed during freeze.
If it can wait it should wait and should not be pushed during freeze.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)