Re: [libvirt] [PATCH 1/2] virsh: really fix the error if vcpu number exceed the guest maxvcpu number

On 07/14/2015 09:10 AM, Luyao Huang wrote: > Commit '848ab68' left a issue: when we try to get a vcpupin info with no > no flags or --current flags, we still will get the wrong error. Because > VIR_DOMAIN_AFFECT_CURRENT is 0, so this check flags & VIR_DOMAIN_AFFECT_CURRENT > will always get false. > > Signed-off-by: Luyao Huang <lhuang(a)redhat.com&gt; > Reported by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > tools/virsh-domain.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > hmmm ... see Michal's patch on this (and my response): http://www.redhat.com/archives/libvir-list/2015-July/msg00555.html Of course when I merged your change when I made the original adjustment based on review, I never ran it through my coverity checker either).

John