RE: [PATCH v4 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface
-----Original Message-----
From: Alistair Francis [mailto:alistair23@gmail.com]
Sent: Tuesday, January 11, 2022 7:10 AM
To: Jiangyifei <jiangyifei(a)huawei.com>
Cc: qemu-devel(a)nongnu.org Developers <qemu-devel(a)nongnu.org>; open
list:RISC-V <qemu-riscv(a)nongnu.org>; kvm-riscv(a)lists.infradead.org; open
list:Overall <kvm(a)vger.kernel.org>; libvir-list(a)redhat.com; Anup Patel
<anup(a)brainfault.org>; Palmer Dabbelt <palmer(a)dabbelt.com>; Alistair
Francis <Alistair.Francis(a)wdc.com>; Bin Meng <bin.meng(a)windriver.com>;
Fanliang (EulerOS) <fanliang(a)huawei.com>; Wubin (H)
<wu.wubin(a)huawei.com>; Wanghaibin (D) <wanghaibin.wang(a)huawei.com>;
wanbo (G) <wanbo13(a)huawei.com>; limingwang (A)
<limingwang(a)huawei.com>; Anup Patel <anup.patel(a)wdc.com>
Subject: Re: [PATCH v4 02/12] target/riscv: Add target/riscv/kvm.c to place the
public kvm interface
On Mon, Jan 10, 2022 at 11:48 AM Yifei Jiang via <qemu-devel(a)nongnu.org>
wrote:
>
> Add target/riscv/kvm.c to place kvm_arch_* function needed by
> kvm/kvm-all.c. Meanwhile, add kvm support in meson.build file.
>
> Signed-off-by: Yifei Jiang <jiangyifei(a)huawei.com>
> Signed-off-by: Mingwang Li <limingwang(a)huawei.com>
> Reviewed-by: Alistair Francis <alistair.francis(a)wdc.com>
> Reviewed-by: Anup Patel <anup.patel(a)wdc.com>
> ---
> meson.build | 2 +
> target/riscv/kvm.c | 133
+++++++++++++++++++++++++++++++++++++++
> target/riscv/meson.build | 1 +
> 3 files changed, 136 insertions(+)
> create mode 100644 target/riscv/kvm.c
>
> diff --git a/meson.build b/meson.build index 53065e96ec..7eaec31a3a
> 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -90,6 +90,8 @@ elif cpu in ['ppc', 'ppc64']
> kvm_targets = ['ppc-softmmu', 'ppc64-softmmu'] elif cpu in
> ['mips', 'mips64']
> kvm_targets = ['mips-softmmu', 'mipsel-softmmu',
'mips64-softmmu',
> 'mips64el-softmmu']
> +elif cpu in ['riscv']
> + kvm_targets = ['riscv32-softmmu', 'riscv64-softmmu']
> else
> kvm_targets = []
> endif
Can you add this as a separate commit at the end of the series?
That way we have implemented KVM support before we enable it for users.
Alistair
Yes, that makes sense.
Yifei