Re: [libvirt PATCH 0/2] Revert mdev autostart support

On Thu, 27 May 2021 14:04:08 +0200 Michal Prívozník <mprivozn(a)redhat.com&gt; wrote: > On 5/26/21 5:40 PM, Jonathon Jongsma wrote: >> As Daniel Berrange mentioned, the method of supporting autostart >> for node devices was not consistent with other libvirt objects. >> This patch series reverts this feature before it gets into a >> release. I will submit a follow-up patch soon which adds the >> feature back with a consistent API. >> >> Jonathon Jongsma (2): >> Partial Revert of "tests: nodedevxml2xmltest: test more mdev >> files" nodedev: Revert auto-start property for mdevs >> >> docs/formatnode.html.in | 10 --------- >> docs/schemas/nodedev.rng | 11 ---------- >> src/conf/node_device_conf.c | 21 >> +------------------ src/conf/node_device_conf.h | >> 12 ----------- src/libvirt_private.syms | 2 -- >> src/node_device/node_device_driver.c | 7 +------ >> .../mdevctl-list-multiple.out.xml | 4 ---- >> tests/nodedevschemadata/mdev_autostart.xml | 10 --------- >> tests/nodedevschemadata/mdev_manual.xml | 10 --------- >> ...v_3627463d_b7f0_4fea_b468_f1da537d301b.xml | 10 +-------- >> tests/nodedevxml2xmlout/mdev_autostart.xml | 11 ---------- >> ...v_d069d019_36ea_4111_8f0a_8c9a70e21366.xml | 1 - >> ...v_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml | 1 - >> ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml | 11 +--------- >> ...v_fedc4916_1ca8_49ac_b176_871d16c13076.xml | 1 - >> tests/nodedevxml2xmlout/mdev_manual.xml | 11 ---------- >> tests/nodedevxml2xmltest.c | 2 -- >> 17 files changed, 4 insertions(+), 131 deletions(-) >> delete mode 100644 tests/nodedevschemadata/mdev_autostart.xml >> delete mode 100644 tests/nodedevschemadata/mdev_manual.xml >> mode change 100644 => 120000 >> tests/nodedevxml2xmlout/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml >> delete mode 100644 tests/nodedevxml2xmlout/mdev_autostart.xml mode >> change 100644 => 120000 >> tests/nodedevxml2xmlout/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml >> delete mode 100644 tests/nodedevxml2xmlout/mdev_manual.xml > > Patches look good. But please reply with your signed-off-by line so > that I can add it to the commits and push. > > Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > > Michal > Sorry, Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com&gt;