Re: [libvirt] [PATCH] Fix several minor problems introduced by the memtune series
On 10/13/2010 02:25 AM, Daniel Veillard wrote:
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -70,6 +70,21 @@ struct remote_sched_param {
> remote_nonnull_string field;
> remote_sched_param_value value;
> };
> +struct remote_memory_param_value {
Hum, that file I didn't know about ... aren't those already
declared in the .x so why the duplication, I'm surprized !
That file only gets modified if you have the 'dwarves' package
installed. It is a manual check that we are not changing the
on-the-wire protocol inadvertently. Yes, it would be nice if this file
could be regenerated automatically, instead of manually updating it; but
the point of having this file is that we are forced to review every
protocol change to make sure it is only additions and not modifications
of an existing struct.
See this thread for its introduction:
https://www.redhat.com/archives/libvir-list/2010-May/msg00152.html
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org