Re: [libvirt] [PATCH] nwfilter: Update of filters to handle multiple IP addresses

On 11/28/2011 09:15 AM, Stefan Berger wrote: > With fragments borrowed from David Steven's previous submission and some > further modifications: > > A set of modifications to existing filters to handle multiple IP addresses > (and MAC addresses) per interface. > > Also: > - enable DHCP traffic from VM to any DHCP server > - will require an update to a libvirt-tck data file > > Signed-off-by: David L Stevens<dlstevens(a)us.ibm.com> > Signed-off-by: Stefan Berger<stefanb(a)linux.vnet.ibm.com> I didn't try to repair the patch, so I didn't compile test it, but I can at least give a v1 review. I do think it is worth including in 0.9.8, since it can be argued that this is just rounding out the nwfilter multiple address fix already going into the release, and since the code was submitted for review pre-freeze. At any rate, glancing through it, it looks okay. ACK.