Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver
On Wed, Apr 30, 2008 at 11:36:33PM +0100, Daniel P. Berrange wrote:
WRT to the network interface type attribute, I advised Soren at the
virt summit in Austin, that since Rich Jones had already posted the
patch and we'd all basically agreed on syntax it was reasonably to
include the patch in Ubuntu. It was only a matter of time before we
merged it - as I have done today.
Thanks very much. That strikes that bit off of my "Stuff I might need to
worry about" list. :)
Now, the disk model syntax supporting virtio is where I agree with
Daniel
that it should have been posted upstream before inclusion in a product Even
if the code was just a quick hack, not in a state fit for merging - it is
always beneficial to post as early as possible just for the sake of
visibility & comment.
This is good advice. Thanks.
This said I believe the proposed 'bus' atribute for disks is
the
optimal way to handle virtio for disks.
I agree. A <model type='foo' /> element in the disk definition could
still be used to specify which particular SCSI controller you'd like.
Just for future enhancements please post ideas to this list asap.
I'll keep that in mind. I'm truly sorry for the stir I've caused and I
have every intention of making sure it won't happen again.
I myself have posted ideas more than 1 year before actually getting
around to implementing them, so there's no requirement to follow
through with code immediately :-)
:)
--
Soren Hansen |
Virtualisation specialist | Ubuntu Server Team
Canonical Ltd. | http://www.ubuntu.com/
Attachments:
- signature.asc (application/pgp-signature — 189 bytes)