Re: [PATCH 2/2] virStorageEncryptionSecretCopy: Properly copy internals
On a Thursday in 2020, Peter Krempa wrote:
virStorageEncryptionSecretPtr may have a string inside it, thus we
must
copy the string too. Use virSecretLookupDefCopy to do that.
Likely caused by 756b46ddd24.
Please remove the period from the end.
Also, at the times of that commit, memcpy was sufficient:
struct _virStorageEncryptionSecret {
int type; /* virStorageEncryptionSecretType */
unsigned char uuid[VIR_UUID_BUFLEN];
};
So this actually fixes commit 47e88b33b which switched to using
virSecretLookupDef.
https://bugzilla.redhat.com/show_bug.cgi?id=1814923
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/util/virstorageencryption.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)