Re: [libvirt] [PATCH 5/9] Include filename explicitly in logging APIs

On 09/27/2012 10:44 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Currently the logging APIs have a 'const char *category' parameter > which indicates where the log message comes from. This is typically > a combination of the __FILE__ string and other prefix. Split the > __FILE__ off into a dedicated parameter so it can passed to the > log outputs >

> + VIR_DEBUG_INT("trace", __FILE__ , __LINE__, __func__, \ While you are touching this line, get rid of the space before comma.

ACK with this squashed in: diff --git i/src/internal.h w/src/internal.h index 8037a4a..f8d9044 100644 --- i/src/internal.h +++ w/src/internal.h @@ -349,10 +349,10 @@ # define PROBE_EXPAND(NAME, ARGS) NAME(ARGS) # define PROBE(NAME, FMT, ...) \ - VIR_DEBUG_INT("trace." __FILE__ , __func__, __LINE__, \ + VIR_DEBUG_INT("trace." __FILE__, __func__, __LINE__, \ #NAME ": " FMT, __VA_ARGS__); \ - if (LIBVIRT_ ## NAME ## _ENABLED()) { \