Re: [libvirt] [PATCH 4/4] remote: Detect 'nc' version incompatibilities
On 02/15/2010 07:40 PM, Jim Fehlig wrote:
Cole Robinson wrote:
> This ugly thing is a shell script to detect availability of
> the -q option for 'nc': debian and suse based distros need this
> flag to ensure the remote nc will exit on EOF, so it will go away
> when we close the tunnel. If it doesn't go away, a useless 'nc'
> process is left sitting on the remote host.
>
I've spent time trying to make this code more flexible with other types
of relays, e.g. socat which can be invoked with
socat - GOPEN:sockname LIBVIRTD_PRIV_UNIX_SOCKET
but haven't come up with anything I would consider upstreamable. Jonas
Eriksson also made a brave attempt [1] :-). Any suggestions for
improving this code to handle other relays at runtime?
If we go Dan's route of just creating a libvirt helper under /usr/libexec, we
shouldn't need to handle other nc type utils AIUI. Aside from that, the only
choice would be to make the shell script even hairier to detect available
binaries on the remote system.
- Cole