Re: [libvirt] [PATCH 3/4] README: Remove 'git send-email' mention
On Mon, 2017-06-26 at 13:23 +0200, Peter Krempa wrote:
> The libvirt project welcomes contributions in many ways. For
most components
> the best way to contribute is to send patches to the primary development
> -mailing list, using the `git send-email` command. Further guidance on this
> -can be found on the website:
> +mailing list. Further guidance on this can be found on the website:
I think you should not drop the hint to git send-email as users kept
sending patches as attachments.
Even after patch 2/4 added a trail from contribute.html
(which was already pointed to by README a couple of lines
after mentioning git send-email) to hacking.html?
We have a lot of information about how to use and configure
git send-email in hacking.html, so I think that people who
stop at the mention in README without going further and
reading the full contributor guidelines will botch sending
the patches in some way regardless. That's why I feel like
mentioning it there is not very helpful.
--
Andrea Bolognani / Red Hat / Virtualization