Re: [libvirt] [libvirt-glib 2/4] Add host capabilities API
On Wed, May 9, 2012 at 7:10 PM, Christophe Fergeau <cfergeau(a)redhat.com> wrote:
+const gchar *
+gvir_config_capabilities_cpu_feature_get_name(GVirConfigCapabilitiesCpuFeature *caps)
s/caps/feature
I was thinking of using 'caps' for all GVirConfigCapabilities*
instances but no strong feelings so I'll change..
+{
g_return_val_if_fail(GVIR_CONFIG_IS_CAPABILITIES_CPU_FEATURE(feature);
+ return gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(caps),
+ NULL,
+ "name");
+}
Can you add the 2 other attributes while you are at it?
Which other 2 attributes? AFAICT from RNG and 'capabilities' xml on my
machine, those attributes only exists in guest features.
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
b/libvirt-gconfig/libvirt-gconfig-object.c
index 0495a3f..30d80a4 100644
--- a/libvirt-gconfig/libvirt-gconfig-object.c
+++ b/libvirt-gconfig/libvirt-gconfig-object.c
@@ -915,4 +915,3 @@ gvir_config_object_get_child(GVirConfigObject *object,
child_name,
GVIR_CONFIG_TYPE_OBJECT);
}
-
This doesn't belong in this patch, feel free to sneak it in a patch
modifying -object.c
Marc-Andre would disagree but sure.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124