Re: [libvirt] [PATCH] qemu: Deny hugepages for non-existent NUMA nodes
On 05/18/2018 07:04 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1534418
Just like ec982f6d929f3c23 denies hugepages for non-existent
guest NUMA nodes in case there are some nodes configured.
Unfortunately, when there are none, qemuBuildNumaArgStr() is not
called and thus we have to have check in qemuBuildMemPathStr()
too.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_command.c | 10 +++++++
tests/qemuxml2argvdata/hugepages-pages8.xml | 41 +++++++++++++++++++++++++++++
tests/qemuxml2argvtest.c | 3 +++
3 files changed, 54 insertions(+)
create mode 100644 tests/qemuxml2argvdata/hugepages-pages8.xml
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
although I'll admit following the reasoning why when
virDomainNumaGetNodeCount is the gate for both qemuBuildNumaArgStr and
qemuBuildMemPathStr didn't make it "easy to understand" ;-).
May be a "/* NB: qemuBuildNumaArgStr was only called when
virDomainNumaGetNodeCount finds numa, so a similar check is not made. */