Re: [PATCH for-5.0 3/4] Remove the core bluetooth code
On Wed, Feb 5, 2020 at 7:03 PM Aleksandar Markovic
<aleksandar.m.mail(a)gmail.com> wrote:
> The deprecation policy is primarily intended for notifying of changes
> to QEMU's stable interfaces ( CLI, HMP, QMP) which affect behaviour
> and usage of QEMU at runtime & are liable to break apps managing
> QEMU.
>
> Changes to build time options have no strong reason to be subjected to
> the deprecation process.
This sounds reasonable to me.
But: Should our deprecation policy be clearer on what is subject to
our deprecation procedure, and what is not?
Regards,
Aleksandar
And, there is even a section devoted to the build system in
https://qemu.weilnetz.de/doc/qemu-doc.html#Deprecated-features :
B.10 Build system
B.10.1 Python 2 support (since 4.1.0)
In the future, QEMU will require Python 3 to be available at build
time. Support for Python 2 in scripts shipped with QEMU is deprecated.
The wording above comes from the file in our source tree: qemu-deprecated.texi .
Shouldn't the cases like "--enable-blues" be documented here? I think
the deprecation of bluetooth devices support should have included a
short section on involved configure options here.
Why is Python 2 support different to "--enable-blues" support? There
should not be some unknown and arbitrary criterium what do and what
doesn't come in this subsection.
Or, if our build system is not subject to our deprecation policy, than
what is the entire subsection "B.10 Build system" doing here, in
section "Deprecated features"?
> If we remove an option at build time the effect
> is noticed immediately and the solution is straightforward (stop passing
> the option). We have added / removed configure options at will with little
> negative feedback historically. We'll have far biggest changes coming to
> the build system in future too, with the introduction of meson.
>
> I don't think we want to constrain & complicate our work in modernizing
> the build system by declaring that any changes to it must go through
> deprecation.
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>