Re: [PATCH 2/2] rpm: Drop unnecessary libiscsi runtime dependency
On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark <jdenemar(a)redhat.com> wrote:
On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> This is automatically picked up by the dependency generator, so
> there's no reason to have this here.
>
> Signed-off-by: Neal Gompa <ngompa13(a)gmail.com>
> ---
> libvirt.spec.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 0a8b0ebad4..41e532102a 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -614,7 +614,6 @@ volumes using the host iscsi stack.
> Summary: Storage driver plugin for iscsi-direct
> Requires: libvirt-daemon-driver-storage-core = %{version}-%{release}
> Requires: libvirt-libs = %{version}-%{release}
> -Requires: libiscsi
The explicit dependency was added by Andrea 2.5 years ago, perhaps he
had reasons to do so. Any comments Andrea?
It most likely dates back to when Fedora had two providers of libiscsi
sharing the same soname. That situation no longer exists today. Other
distributions also don't have that issue.
--
真実はいつも一つ！/ Always, there's only one truth!