Re: [PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP commands

On 24/02/2021 14.11, Daniel P. Berrangé wrote: > The VNC ACL concept has been replaced by the pluggable "authz" framework > which does not use monitor commands. > > Reviewed-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com&gt; > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > docs/system/deprecated.rst | 16 --- > docs/system/removed-features.rst | 13 +++ > hmp-commands.hx | 76 ------------- > monitor/misc.c | 187 ------------------------------- > ui/vnc.c | 38 ------- > 5 files changed, 13 insertions(+), 317 deletions(-) If I run: grep -r vnc.*acl * I also see some lines in tests/check-block-qdict.c ... are they related and should be removed, too?

Apart from that, patch looks fine to me: Reviewed-by: Thomas Huth <thuth(a)redhat.com&gt;