Re: [libvirt] [PATCH 01/10] conf: Renamed 'controlBuf' to 'childrenBuf'
-----Original Message-----
From: John Ferlan [mailto:jferlan@redhat.com]
Sent: Wednesday, September 5, 2018 7:58 PM
To: Wang, Huaqiang <huaqiang.wang(a)intel.com>; libvir-list(a)redhat.com
Cc: Feng, Shaohe <shaohe.feng(a)intel.com>; Niu, Bing <bing.niu(a)intel.com>;
Ding, Jian-feng <jian-feng.ding(a)intel.com>; Zang, Rui <rui.zang(a)intel.com>
Subject: Re: [libvirt] [PATCH 01/10] conf: Renamed 'controlBuf' to
'childrenBuf'
Hi John,
Thanks for review.
Will address your comments in each separate email.
BR
Huaqiang
On 08/27/2018 07:23 AM, Wang Huaqiang wrote:
> To add CMT/MBM feature and let code be consistent in later patches,
> renaming variable name from 'controlBuf' to 'childrenBuf', locates
in
> functions 'virCapabilitiesFormatCaches' and
> 'virCapabilitiesFormatMemoryBandwidth'.
>
> Signed-off-by: Wang Huaqiang <huaqiang.wang(a)intel.com>
> ---
> .gnulib | 1 -
Gaah!!!
Don't do that!
Will be removed.
> src/conf/capabilities.c | 28 ++++++++++++++--------------
> 2 files changed, 14 insertions(+), 15 deletions(-) delete mode
> 160000 .gnulib
>
> diff --git a/.gnulib b/.gnulib
> deleted file mode 160000
> index 68df637..0000000
> --- a/.gnulib
> +++ /dev/null
> @@ -1 +0,0 @@
> -Subproject commit 68df637b5f1b5c10370f6981d2a43a5cf74368df
Luckily I can delete this hunk out of my .eml file before git am'ing the series.
The rest is fine by me, allows childrenBuf to catch up with childBuf variables. At
least in this case there's multiple elements within for loops being added as
opposed to some other uses where there's just one.
Thanks.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John