Re: [libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers

On Wed, Apr 03, 2019 at 01:34:04PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 03, 2019 at 02:29:55PM +0200, Martin Kletzander wrote: > > On Wed, Apr 03, 2019 at 11:41:41AM +0100, Daniel P. Berrangé wrote: > > > For a while QEMU has provided simple make rules for building QEMU inside > > > standard docker container environments. This provides an equivalent > > > mechanism for libvirt inspired by QEMU's. > > > > Can we change this so that we don't mention docker everywhere? These are just > > containers and you can run them using other tools with no docker dependency. I > > know I can set an alias docker=podman and it will just work, but now that > > podman, buildah, skopeo and others work on my machine (even non-systemd one) I > > think it would be nice stop requiring "docker" if it is not needed. And to make > > Dan Walsh not cringe that much. > > The patch series invokes docker from the Makefile and the CI systems we > are targetting with this also use docker, so it is not wrong to refer to > docker. Furthermore everyone knows what you mean when you refer to docker, > while only a subset of people will have any idea what podman is. I'm suggesting s/docker containers/containers/ in commit messages and comments and maybe (but I can add that later) testing whether you have at least one of docker/podman installed in the makefile and using that instead of hardcoding the "docker" string in there. Feel free to ignore my suggestion, I just thought it would be nice if we were a bit more inclusive instead of using proprietary eponyms.