Re: [libvirt PATCH] hypervisor: Move interface mgmt methods to hypervisor

On 10/12/23 3:37 PM, Praveen K Paladugu wrote: > Move guest interface management methods from qemu to hypervisor. These > methods will be shared by networking support in ch driver. > > Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com&gt; > --- > po/POTFILES | 1 + > src/hypervisor/domain_interface.c | 279 ++++++++++++++++++++++++++++++ > src/hypervisor/domain_interface.h | 38 ++++ > src/hypervisor/meson.build | 1 + > src/libvirt_private.syms | 6 + > src/qemu/qemu_command.c | 7 +- > src/qemu/qemu_hotplug.c | 3 +- > src/qemu/qemu_interface.c | 246 +------------------------- > src/qemu/qemu_interface.h | 6 - > src/qemu/qemu_process.c | 3 +- > 10 files changed, 341 insertions(+), 249 deletions(-) > create mode 100644 src/hypervisor/domain_interface.c > create mode 100644 src/hypervisor/domain_interface.h > > diff --git a/po/POTFILES b/po/POTFILES > index 3a51aea5cb..023c041f61 100644 > --- a/po/POTFILES > +++ b/po/POTFILES > @@ -92,6 +92,7 @@ src/hyperv/hyperv_util.c > src/hyperv/hyperv_wmi.c > src/hypervisor/domain_cgroup.c > src/hypervisor/domain_driver.c > +src/hypervisor/domain_interface.c > src/hypervisor/virhostdev.c > src/interface/interface_backend_netcf.c > src/interface/interface_backend_udev.c > diff --git a/src/hypervisor/domain_interface.c b/src/hypervisor/domain_interface.c > new file mode 100644 > index 0000000000..b01b6ee767 > --- /dev/null > +++ b/src/hypervisor/domain_interface.c > @@ -0,0 +1,279 @@ > +/* > + * Copyright Microsoft Corp. 2023 I haven't had time to look through the rest of this yet (although it seems pretty straightforward, and I think it might have been me who suggested it in the first place :-)), I did want to bring up this one topic now: Best practices for the copyright notice in a new file have changed over the years (for example, we no longer list the "Author" of new files and even removed Author from existing files, since a more accurate and complete version of that info is all available from git), and I haven't paid close attention, but since this entire file is comprised of functions that were just moved from an existing file and renamed (rather than actual new code), I don't think it's appropriate for it to erase all trace of the original copyright holder and simply assign the copyright entirely to Microsoft.