Re: [libvirt] [PATCH v2 1/5] cpu_models: add new public API

On Sat, Sep 07, 2013 at 01:11:22AM +0200, Giuseppe Scrivano wrote: > The new function virConnectGetCPUModelNames allows to retrieve the list > of CPU models known by the hypervisor for a specific architecture. > > Signed-off-by: Giuseppe Scrivano <gscrivan(a)redhat.com&gt; > --- > include/libvirt/libvirt.h.in | 18 +++++++++++++ > python/generator.py | 1 + > src/cpu/cpu.c | 64 ++++++++++++++++++++++++++++++++++++++++++++ > src/cpu/cpu.h | 3 +++ > src/driver.h | 7 +++++ > src/libvirt.c | 47 ++++++++++++++++++++++++++++++++ > src/libvirt_private.syms | 1 + > src/libvirt_public.syms | 5 ++++ > tools/virsh-host.c | 48 +++++++++++++++++++++++++++++++++ > tools/virsh.pod | 5 ++++ It is preferrable to have virsh changes separate from the public API addition. Likewise I'd suggest th src/cpu/ changes be a separate patch.