Re: [Libvir] [PATCH] Readd buffer errors & some cleanups

On Tue, Jul 03, 2007 at 11:47:20AM +0100, Richard W.M. Jones wrote: > This readds some error checking of the returns from virBuffer* > functions, removes need for is_blank (a _GNU_SOURCE extension), and a > couple of other very minor cleanups. Looks fine to me, I just wonder about: - while (p && *p && isblank((unsigned char) *p)) + while (p && *p && (*p == ' ' || *p == '\t')) I don't think we have support for multiline commands so this should be fine, but '\n' and '\r' could be tested too. in any case +1