Re: [libvirt] [PATCH v5 3/3] allow "virsh dump --memory-only" specify dump format

On Wed, Mar 12, 2014 at 05:18:22PM +0000, Daniel P. Berrange wrote: > > On Thu, Mar 06, 2014 at 09:35:47AM +0000,qiaonuohan(a)cn.fujitsu.com wrote: >> > > This patch is used to add "--compress" and "[--compression-format]<string>" to >> > > "virsh dump --memory-only". And "virsh dump --memory-only" is going be >> > > implemented by new virDomainCoreDumpWithFormat API. >> > > >> > > Signed-off-by: Qiao Nuohan&lt;qiaonuohan(a)cn.fujitsu.com&gt; >> > > --- >> > > tools/virsh-domain.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- >> > > 1 file changed, 44 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >> > > index 2e3f0ed..70613e5 100644 >> > > --- a/tools/virsh-domain.c >> > > +++ b/tools/virsh-domain.c >> > > @@ -4486,6 +4486,14 @@ static const vshCmdOptDef opts_dump[] = { >> > > .type = VSH_OT_BOOL, >> > > .help = N_("dump domain's memory only") >> > > }, >> > > + {.name = "compress", >> > > + .type = VSH_OT_BOOL, >> > > + .help = N_("make qemu dump domain's memory in kdump-compressed format") >> > > + }, >> > > + {.name = "compression-format", >> > > + .type = VSH_OT_DATA, >> > > + .help = N_("specify the compression format of kdump-compressed format") >> > > + }, > > > > As before, IMHO having two args here is silly. Just have a > > single '--compress format' arg. > > I'm fine with having one param only, I don't know about the author, though. I also proposed '--compress' as an alias which should be good compromise IMHO.