Re: [PATCH] meson: Detect rst2html5 and rst2man only when needed
On Thu, Jan 13, 2022 at 08:40:56AM +0000, Ivan Teterevkov wrote:
+++ b/meson.build
@@ -788,8 +788,6 @@ required_programs = [
required_programs_groups = [
{ 'name': 'rpcgen', 'prog': [ 'rpcgen',
'portable-rpcgen' ] },
- { 'name': 'rst2html5', 'prog': [ 'rst2html5',
'rst2html5.py', 'rst2html5-3' ] },
- { 'name': 'rst2man', 'prog': [ 'rst2man',
'rst2man.py', 'rst2man-3' ] },
]
I wonder if we could avoid looking for rpcgen unless the remote
driver is enabled? I'm not entirely sure that would work, and the
benefits of a remote-less build are less obvious.
Anyway, your patch is
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
I'll push it once 8.0.0 has been released.
Congratulations on your first contribution to libvirt :)
--
Andrea Bolognani / Red Hat / Virtualization