Re: [libvirt] [C# bindings][PATCH] Add/Clean comments and virConnecSetErrorFunc Sample
Your patches in general are okay, no problem with that. :)
It's just that this patch contains 3 independent changes. As a general
rule of thumb you should do one thing per commit. This makes things
simpler to review and track.
Also the "Correct virDomainInfo marshaling" part could be explained in
a bit more details in the commit message. Like try to answer the
question: What was wrong with it and how did you fix it?
Matthias
2010/11/1 <arnaud.champion(a)devatom.fr>:
Okay,
anyway, I think my patches are not well formatted and/or sometime
"inconsistent" I don't know the well word.
Can you explain me what is a "good" patch, just for make less work for you ?
Regards,
Arnaud
--------------------------------------------------
From: "Matthias Bolte" <matthias.bolte(a)googlemail.com>
Sent: Monday, November 01, 2010 7:15 PM
To: <arnaud.champion(a)devatom.fr>
Cc: <libvir-list(a)redhat.com>
Subject: Re: [libvirt] [C# bindings][PATCH] Add/Clean comments and
virConnecSetErrorFunc Sample
> 2010/10/30 <arnaud.champion(a)devatom.fr>:
>>
>> Hi,
>>
>> here is a new patch, it add/correct some comments. It also make
>> virDomainInfo marshaling working. It also add a new sample
>> virConnectSetErrorFunc to show usage of virConnectSetErrorFunc, virError
>> struct, virDomainInfo struct.
>>
>> Regards,
>>
>> Arnaud
>>
>
> Actually this patch contains 3 independent things:
>
> - Add / cleaning comments
> - New sample virConnectSetErrorFunc
> - Correct virDomainInfo marshaling
>
> Therefore, I'd like to see this split up into 3 separate patches.
>
> Matthias
>