Re: [libvirt] [PATCH 06/10] vl.c: handle invalid NUMA CPU ranges properly

On 01/11/2013 11:15 AM, Eduardo Habkost wrote: > Add checks for the following cases: > > * Empty string: will be ignored and won't set any CPU bitmap, > parser won't abort. > * Missing end value after "-": parser will abort. > * Extra characters after a valid CPU range: parser will abort. > * "N-M" string where M < N: parser will abort. > value = strtoull(cpus, &endptr, 10); > if (*endptr == '-') { > - endvalue = strtoull(endptr+1, &endptr, 10); > + endptr++; > + if (!*endptr) { > + goto error; > + } > + endvalue = strtoull(endptr, &endptr, 10); > } else { > endvalue = value; > } Still missing a check for '-numa=-2' with no number on the left of '-', as well as missing a check for overflow for -numa=999999999999999999999999