Re: [libvirt] [PATCH v3 1/3] docs, conf, schema: add support for shmem device
Hi Martin,
On Fri, Oct 3, 2014 at 10:45 PM, Martin Kletzander <mkletzan(a)redhat.com> wrote:
On Thu, Oct 02, 2014 at 09:42:36AM +0200, Michal Privoznik wrote:
>
> On 26.09.2014 12:43, Martin Kletzander wrote:
>>
>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>> index b114737..51bdd31 100644
>> --- a/src/conf/domain_conf.c
>> +++ b/src/conf/domain_conf.c
>
>
[..]
>
Nice catch.
Since we are past the release anyway, I'm going to push this in a
while and whoever wants (e.g. Maxime) have the whole release cycle to
test this.
Thanks for pushing/cleaning the shmem patches support (i.e
http://www.redhat.com/archives/libvir-list/2014-August/msg01032.html)
But you did miss the following:
1. the ivshmem server autostart feature: you wanted me to develop it
into the v1. (i.e.
http://www.redhat.com/archives/libvir-list/2014-August/msg01432.html)
2. You did not wait for my tests. Why should I ask you to wait for my tests?
Lucky enough, now I have the results of the tests, everything works fine ;)
I don't understand why it became so urgent to push these patches.
Anyway, I am glad that libvirt supports ivshmem.
Since now you pushed these patches, do you plan to provide the ivshmem
autostart feature like you requested previously ?
I'll be glad to review it and to provide feedbacks based on my tests.
Maxime