Re: [libvirt] [PATCH v4 1/8] virpcimock: Adapt to virmock.h
On Fri, May 13, 2016 at 14:32:02 +0200, Michal Privoznik wrote:
Instead of introducing our own wrapper for dlsym()
we can use the one provided by virmock.h.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
tests/virmock.h | 10 ++++++
tests/virpcimock.c | 97 ++++++++++++++++++++++--------------------------------
2 files changed, 50 insertions(+), 57 deletions(-)
[...]
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index cfe42a6..c7786e5 100644
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -21,10 +21,7 @@
#include <config.h>
#ifdef __linux__
-# include "internal.h"
-# include <stdio.h>
-# include <dlfcn.h>
-# include <stdlib.h>
stdio.h (fprintf) and stdlib.h (abort) are still used by this file so
you probably should not remove the headers.
+# include "virmock.h"
# include <unistd.h>
# include <fcntl.h>
# include <sys/stat.h>
ACK to the rest.
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)