Re: [libvirt] [PATCH v4 0/7] Console corruption patchset

Rebased and tweaked to current upstream. Some patches still need review: * 1/7 pidfile: Make checking binary path in virPidFileRead optional - ACKed in v3 by Eric - minor spelling fixes * 2/7 Add flags for virDomainOpenConsole - ACKed in v3 by Eric - spelling fixes - added docs about behavior with older server suggested by Eric * 3/7 virsh: add support for VIR_DOMAIN_CONSOLE_* flags - ACKed in v3 by Eric - tweaked grammar/spelling - added reason why --safe and --force was not implemented in start/create * 4/7 fdstream: Emit stream abort callback even if poll() doesnt. - no change to v3 - Eric requested final ack by danpb * 5/7 fdstream: Add internal callback on stream close - no change to v3 - needs review * 6/7 util: Add helpers for safe domain console operations - fixed include of hash.h -> virhash.h - needs review of changes done in v3 * 7/7 qemu: Add ability to abort existing console while creating new one - needs review of changes done in v3 configure.ac | 39 ++++- include/libvirt/libvirt.h.in | 12 ++ po/POTFILES.in | 1 + src/Makefile.am | 6 +- src/conf/virconsole.c | 396 ++++++++++++++++++++++++++++++++++++++++++ src/conf/virconsole.h | 36 ++++ src/fdstream.c | 89 +++++++++- src/fdstream.h | 11 ++ src/libvirt.c | 18 ++- src/libvirt_private.syms | 6 + src/qemu/qemu_domain.c | 5 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 21 ++- src/util/virpidfile.c | 21 ++- tools/console.c | 5 +- tools/console.h | 3 +- tools/virsh.c | 24 ++- tools/virsh.pod | 8 +- 18 files changed, 666 insertions(+), 38 deletions(-) create mode 100644 src/conf/virconsole.c create mode 100644 src/conf/virconsole.h