Re: [libvirt] [PATCH] Solaris least privilege support
On Mon, Jan 19, 2009 at 04:32:44PM +0100, Daniel Veillard wrote:
> > that this code would fail except in the first time the
daemon is
> > launched because mkdir /var/run/libvirt will return -1 and errno EEXIST
> > in all following cases. I'm worried about this,
>
> What do you mean? /var/run is a tmpfs on Solaris so must mkdir after
> every reboot.
I don't see any #ifdef __sun around that part of the patch, so
I assume it need to be valid for all OSes. Moreover if you kill and
restart the daemon, I would assume that chunk to fail too. So this need
to be fixed IMHO before commit.
I don't think you've read the code correctly. A mkdir of an existing
directory will not fail.
regards
john