Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

>> +const gchar *gvir_config_domain_hostdev_pci_get_rom_file(GVirConfigDomainHostdevPci *hostdev) >> +{ >> + return gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(hostdev), "rom", "file"); > >> +} >> + >> +gboolean gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci *hostdev) >> +{ >> + return gvir_config_object_get_attribute_boolean(GVIR_CONFIG_OBJECT(hostdev), >> + "rom", "bar", FALSE); > > I'd prefer to handle on/off parsing here rather than moving it to > get_attribute_boolean(). Why? Quick look through libvirt XML docs, shows that on/off is used in other places too.

> I don't know whether we should return TRUE or > FALSE as the default value as this depends on the QEMU version :( > "If no rom bar is specified, the qemu default will be used (older > versions of qemu used a default of "off", while newer qemus have a > default of "on")" Maybe we can go with newer behaviour depending on whether or not rom file is set and leave a comment here about this?