Re: [libvirt] [PATCH 13/14] Add suspend info to Xen, LXC and UML hypervisor capabilities
On Tue, Nov 29, 2011 at 09:56:43AM -0700, Eric Blake wrote:
On 11/29/2011 08:44 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> * src/lxc/lxc_conf.c, src/uml/uml_conf.c,
> src/xen/xen_hypervisor.c: Initialize suspend capabilities
> * tests/xencapsdata/*xml: Add empty powermgmt capabilities
Do we need to fake anything in the tests directory to ensure that the
tests never probe the system, but always treat things as no power
management available? I'm worried that running the testsuite as root on
a Dom0 host might cause spurious test failures, although I have not yet
tested that. I guess we can deal with the fallout later if it turns out
to be a problem in practice.
Yes, I already made that mistake, and this patch ensures it does not
get run during test suites :-)
> @@ -71,6 +73,9 @@ virCapsPtr lxcCapsInit(void)
> VIR_WARN("Failed to query host NUMA topology, disabling NUMA
capabilities");
> }
>
> + if (virNodeSuspendGetTargetMask(&caps->host.powerMgmt) < 0)
> + VIR_WARN("Failed to get host power management capabilities");
> +
For qemu, you skipped the warning for qemu:///session (ie. geteuid() was
non-zero). Should we do the same for lxc and uml, or are these
hypervisors only ever useful as root?
Actually it doesn't fail for non-root - the commands for querying
supported PM features are fine to run as non-root.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|