On Fri, Mar 08, 2024 at 10:47:12AM +0100, Michal Prívozník wrote:
On 2/28/24 13:40, Andrea Bolognani wrote:
> On Wed, Feb 28, 2024 at 12:37:54PM +0100, Michal Prívozník wrote:
>> On 2/27/24 19:30, Andrea Bolognani wrote:
>>> This applies on top of [1]. Test pipeline: [2]
>>>
>>> Upon further investigation, I have determined that not only
>>> we are unintentionally using the Linux APIs on FreeBSD instead
>>> of the native ones, but we are also accidentally skipping some
>>> setup steps on Linux.
>>>
>>> [1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/CX...
>>
>> Any reason for not merging these ^^^ yet? It would be nice to merge them
>> before the release and have one broken release less.
>
> I'm giving Roman a chance to provide feedback, since I'm changing
> code that he introduced specifically for FreeBSD.
I think there was enough room given for feedback. Unfortunately, it
missed the release, but there's no reason for it to miss another one.
Agreed. I'm off next week, but I'll push the patches once I come back
unless I hear otherwise. That will still give us plenty of time to
revert them before release, should that turn out to be necessary.
I could also push the patches in this series at the same time, if
someone ACKed them... *hint hint* ;)
--
Andrea Bolognani / Red Hat / Virtualization