Re: [libvirt] [PATCH v3 2/2] maint: prohibit empty first lines

>> It started to fail for me with this change: >> >> prohibit_empty_first_line >> tools/libvirt_win_icon_16x16.ico:1: > > Hmm, it might be simpler just to globally exclude all image formats, > rather than repeating lists of image files in affected rules. > Definitely. It's weird, though, that I'm not seeing this problem. Is it because I'm building on Linux? Why didn't some test box we have fail as well?

> but my thoughts are that we should really ditch those one-off exception > lists for graphic binary files, and instead modify this list: > > VC_LIST_ALWAYS_EXCLUDE_REGEX = \ > (^(HACKING|docs/(news\.html\.in|.*\.patch))|\.po)$$ > And this looks like the right way to go. It would deal with possible future problems as well. After figuring out the parentheses, I can ACK this to go in if you want. I'm hoping to get to cleaning up the excludes one day.