Re: [libvirt] [PATCH] eliminate strerror from qemu_driver.c: use virReportSystemError instead
On Mon, Feb 02, 2009 at 11:38:33AM +0100, Jim Meyering wrote:
Jim Meyering <jim(a)meyering.net> wrote:
> "Daniel P. Berrange" <berrange(a)redhat.com> wrote:
>> On Thu, Jan 29, 2009 at 09:54:59PM +0100, Jim Meyering wrote:
>>> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
>> You can actually just kill off the SetNonBlock method, since we
>> added one to util.h. We should probably do same for SetCloseExec
>> since I believe we have several copies of that with the sme
>> problem too.
FYI, here's how I am now removing uses of strerror.
This is less invasive than what I proposed initially, and
(importantly) it's far easier to automate the transformation.
I'll post the full patch soon.
This seems like a reasonable approach
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|