Re: [libvirt] [PATCH 1/5] add ploop fs driver type

On 01/12/2015 06:39 PM, Michal Privoznik wrote: > On 26.12.2014 15:43, Dmitry Guryanov wrote: >> Ploop is a pseudo device which makes possible to access >> to an image in a file via block device, like loop devices, >> but with additional features: snapshots, write tracker >> and without double-caching. >> >> It used in PCS for containers and in OpenVZ. You can manage >> ploop devices and images with ploop utility >> (http://git.openvz.org/?p=ploop). >> >> Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com&gt; >> --- >> src/conf/domain_conf.c | 3 ++- >> src/conf/domain_conf.h | 1 + >> src/qemu/qemu_command.c | 1 + >> 3 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >> index aafc05e..b502b50 100644 >> --- a/src/conf/domain_conf.c >> +++ b/src/conf/domain_conf.c >> @@ -374,7 +374,8 @@ VIR_ENUM_IMPL(virDomainFSDriver, >> VIR_DOMAIN_FS_DRIVER_TYPE_LAST, >> "path", >> "handle", >> "loop", >> - "nbd") >> + "nbd", >> + "ploop") >> >> VIR_ENUM_IMPL(virDomainFSAccessMode, VIR_DOMAIN_FS_ACCESSMODE_LAST, >> "passthrough", >> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h >> index 57297cd..44f00a0 100644 >> --- a/src/conf/domain_conf.h >> +++ b/src/conf/domain_conf.h >> @@ -791,6 +791,7 @@ typedef enum { >> VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE, >> VIR_DOMAIN_FS_DRIVER_TYPE_LOOP, >> VIR_DOMAIN_FS_DRIVER_TYPE_NBD, >> + VIR_DOMAIN_FS_DRIVER_TYPE_PLOOP, >> >> VIR_DOMAIN_FS_DRIVER_TYPE_LAST >> } virDomainFSDriverType; >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c >> index d5679de..077962f 100644 >> --- a/src/qemu/qemu_command.c >> +++ b/src/qemu/qemu_command.c >> @@ -151,6 +151,7 @@ VIR_ENUM_IMPL(qemuDomainFSDriver, >> VIR_DOMAIN_FS_DRIVER_TYPE_LAST, >> "local", >> "handle", >> NULL, >> + NULL, >> NULL); >> >> VIR_ENUM_DECL(qemuNumaPolicy) >> > > This extends domain XML space. That always must go hand in hand with > RNG schema adjustment and some documentation. Introduction of a test > case is strongly recommended too. I can't ACK a patch without it, sorry. OK, I'll extend RNG schema and add documentation. Could you, please, point to some tests, which I can use as a sample?