Re: [Libvir] PATCH: Fix remote driver to handle network API for local non-QEMU

On Fri, Jun 29, 2007 at 03:08:47PM +0100, Daniel P. Berrange wrote: > On Wed, Jun 27, 2007 at 07:04:00PM +0100, Daniel P. Berrange wrote: > > +#define GET_NETWORK_PRIVATE(conn,retcode) \ > + struct private_data *priv = (struct private_data *) (conn)->networkPrivateData; \ > + assert (priv); \ > + if (priv->magic == DEAD) { \ > + error (conn, VIR_ERR_INVALID_ARG, \ > + "tried to use a closed or uninitialised handle"); \ > + return (retcode); \ > + } \ > + assert (priv->magic == MAGIC) > + > static int call (virConnectPtr conn, struct private_data *priv, int in_open, int proc_nr, xdrproc_t args_filter, char *args, xdrproc_t ret_filter, char *ret); Hum .... asserts .... Can't we make a normal test/error/exit handling so that errors there can be chanelled the same way as any other ?

[...] > + > +/* Must not overlap with virDrvOpenFlags */ > +enum { > + VIR_DRV_OPEN_REMOTE_UNIX = (1 << 8), > + VIR_DRV_OPEN_REMOTE_USER = (1 << 9), > + VIR_DRV_OPEN_AUTOSTART = (1 << 10), > +} virDrvOpenRemoteFlags; then maybe both enums definitions should be defined next to each other finding the requirement when editing somewhere else relies on luck, let's move the definition closer.