Re: [libvirt] [PATCH v6 01/13] conf: Add definitions for 'uid' and 'fid' PCI address attributes

On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: [...] > struct _virPCIDeviceAddress { > unsigned int domain; > unsigned int bus; > unsigned int slot; > unsigned int function; > int multi; /* virTristateSwitch */ > + virZPCIDeviceAddress zpci; > }; It's kinda weird that we add the zPCI part right away but the flags which should be used to figure out whether the zPCI part should be taken into account only later, but I can live with that :) Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt;